Prover fixes for Bitwise32Chip #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #130.
Currently, the prover for the
Bitwise32Chipcomputes the bit decomposition of the inputs but does not record the result in the trace. Additionally,Or32instructions were mistakenly being processed asAnd32instructions.The former error is causing the proof for any bitwise instruction (with nonzero inputs) not to verify, and the latter causes the proof for any
Or32instruction whose output is different thanAnd32for the same inputs to fail to verify. This can be seen currently in several tests in the test suite resulting inOodEvaluationMismatcherrors on Chip 10: with this PR, those errors all disappear.